Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: rider (original, plain-wordmark) #1106

Merged
merged 4 commits into from
Mar 29, 2022
Merged

new icon: rider (original, plain-wordmark) #1106

merged 4 commits into from
Mar 29, 2022

Conversation

thehedgefrog
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1071

Link to prove your SVG is correct and up-to-date.

Rider product site

@thehedgefrog
Copy link
Contributor Author

I feel there might be an issue with the plain-wordmark file, while looking at it with the transparency grid I had not noticed the white text is a while fill, not transparent. If need be, close this PR and I will resubmit the wordmark as original-wordmark in a new PR.

@Panquesito7 Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 28, 2022
@github-actions

This comment was marked as outdated.

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem with the transparency in the icon:
image

@thehedgefrog
Copy link
Contributor Author

thehedgefrog commented Mar 28, 2022

There's a problem with the transparency in the icon

Should be good to go now.

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 28, 2022
@devicons devicons deleted a comment from github-actions bot Mar 28, 2022
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 28, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons looking good so far, but we require a original or plain version as statet in our requirements https://github.com/devicons/devicon/wiki/SVG-Versions. The wordmark version for the font is not enough so satisfy this requiredment. Maybe you could create a plain version?

@thehedgefrog
Copy link
Contributor Author

Icons looking good so far, but we require a original or plain version as statet in our requirements https://github.com/devicons/devicon/wiki/SVG-Versions. The wordmark version for the font is not enough so satisfy this requiredment. Maybe you could create a plain version?

Is the original version in my first commit not acceptable?

@amacado
Copy link
Member

amacado commented Mar 28, 2022

Sorry. My answer was incomplete: We need a original or plain version which can be made into a font. Since the current original is not suitable for a font we need a plain version

@thehedgefrog
Copy link
Contributor Author

Sorry. My answer was incomplete: We need a original or plain version which can be made into a font. Since the current original is not suitable for a font we need a plain version

Got it, thanks for clarifying

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 29, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@amacado amacado merged commit 0b5113c into devicons:develop Mar 29, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Rider icons

* Add Rider icons

This reverts commit 7dda239.

* Fixed Rider wordmark icon

* Added plain variation
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Rider icons

* Add Rider icons

This reverts commit 7dda239.

* Fixed Rider wordmark icon

* Added plain variation
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Rider icons

* Add Rider icons

This reverts commit 7dda239.

* Fixed Rider wordmark icon

* Added plain variation
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants